[FFmpeg-devel] [PATCH v3 1/2] fftools/ffmpeg_filter, ffplay: Add flip support to rotation

Moritz Barsnick barsnick at gmx.net
Tue May 7 12:04:24 EEST 2019


On Mon, May 06, 2019 at 22:36:41 -0700, Jun Li wrote:
> +double av_display_rotation_hflip_get(const int32_t matrix[9], int *hflip)
> +{
> +    int32_t m[9];
> +    *hflip = 0;
> +    memcpy(m, matrix, sizeof(int32_t) * 9);

You were asked to avoid this (at another code location though).
BTW, sizeof(m) would be a better use of sizeof() here. (Or a constant
for the triple but related use of "9".)

> +    return av_display_rotation_get(m);
> +}
> \ No newline at end of file

Cosmetic, but please add a line feed in the last line of the file.

Moritz


More information about the ffmpeg-devel mailing list