[FFmpeg-devel] [PATCH 0/3] *** VDPAU: HEVC YUV 4:4:4 Support ***

[Manoj Bonda]

Thanks Philip for pushing the changes, sorry for the churn. 

I am not familiar with the MPV code much, but from a quick check by enabling the direct mode for 444 surfaces by modifying the condition

    p->direct_mode = mapper->dst_params.hw_subfmt == IMGFMT_NV12 ||
                     mapper->dst_params.hw_subfmt == IMGFMT_420P ||
to
    p->direct_mode = mapper->dst_params.hw_subfmt == IMGFMT_NV12 ||
                     mapper->dst_params.hw_subfmt == IMGFMT_420P ||
                     mapper->dst_params.hw_subfmt == IMGFMT_444P;

the playback seems to be fine. But I see this might be since we are downscaling the chroma texture
in function mapper_map ?

I don’t see semi-planar formats for 444 in MPV code. 
VDPAU OpenGL interop supports only semiplanar surfaces as per the spec (https://www.khronos.org/registry/OpenGL/extensions/NV/NV_vdpau_interop2.txt)
I see the proper way to enable direct mode in MPV is to add support for 444 semiplanar format. Please correct me if I am wrong. 

Sorry, but I won’t have bandwidth to take up this MPV task now. I will try to get back to it once I find some time. 

Thanks, 
ManojGupta.

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Philip
> Langdale
> Sent: Monday, May 6, 2019 12:08 AM
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH 0/3] *** VDPAU: HEVC YUV 4:4:4 Support
> ***
> 
> On Thu, 25 Apr 2019 22:00:16 -0700
> Philip Langdale <philipl at overt.org> wrote:
> 
> > On Fri, 26 Apr 2019 09:43:39 +0530
> > ManojGuptaBonda <mbonda at nvidia.com> wrote:
> >
> > > Latest generation video decoder on Turing Chips supports decoding
> > > HEVC 4:4:4 decoding. These changes adds support for the same for
> > > VDPAU
> > >
> > > ManojGuptaBonda (3):
> > >   VDPAU: Add support for decoding HEVC 4:4:4 content
> > >   Pass sps and pps range extension flags to VDPAU.
> > >   Map 444 pix fmts to new VdpYCbCr types defined in VDPAU.
> > >
> > >  libavcodec/hevcdec.c        |  9 +++++++-
> > >  libavcodec/vdpau_hevc.c     | 41
> > > +++++++++++++++++++++++++++++++++++++ libavcodec/vdpau_internal.h
> |
> > > 3 +++ libavutil/hwcontext_vdpau.c |  8 ++++----
> > >  4 files changed, 56 insertions(+), 5 deletions(-)
> > >
> >
> > Hi Manoj,
> >
> > Thanks for putting these patches together. I'll push these this
> > weekend if there aren't any comments from anyone else.
> >
> 
> I've pushed them with version bumps, changelog, and a couple of fixes to
> #define checks because you can't check for the PROFILE which was added
> ages ago. Need to check for the new FORMAT instead.
> 
> Thanks,
> 
> --phil
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request at ffmpeg.org
> with subject "unsubscribe".