[FFmpeg-devel] [Patch] beautified + accelerated vf_fillborders – Please review

Carl Eugen Hoyos ceffmpeg at gmail.com
Thu Mar 28 23:45:14 EET 2019


2019-03-28 22:01 GMT+01:00, Ulf Zibis <Ulf.Zibis at cosoco.de>:
> Hi again,
>
> Am 25.03.19 um 12:31 schrieb Ulf Zibis:
>>> There are two patches "1", one with wrong indentation.
>> I intentionally have provided 2 patches with the same number, one for
>> the code base an one with additions for the benchmark. I've catched the
>> wrong indentation, hopefully at the place you meant.
>>
>> I'm preparing a new set of patches to follow your advice.
>>
>>> Do I read the results correctly that for all patches some cases
>>> get faster and others get slower?
>> Correct. I'm wondering about the cases, where it gets such slower. So
>> I'm interested in an answer from you experienced developers to
>> understand this. Maybe a compiler option would help.
>
> Here they are, my new set of patches.

Patch 1 is wrong.

I don't understand the benchmarks (actually benchmark) you attached
but before sending another patch, you may want to wait for a comment
from Paul, he maintains this filter.

Carl Eugen


More information about the ffmpeg-devel mailing list