[FFmpeg-devel] [Patch] beautified + accelerated vf_fillborders – Please review

[Ulf Zibis]

Am 26.03.19 um 17:20 schrieb Carl Eugen Hoyos:
> 2019-03-26 17:17 GMT+01:00, Ulf Zibis <Ulf.Zibis at cosoco.de>:
>> Am 26.03.19 um 16:32 schrieb Carl Eugen Hoyos:
>>> 2019-03-26 16:28 GMT+01:00, Ulf Zibis <Ulf.Zibis at cosoco.de>:
>>>> Am 26.03.19 um 16:10 schrieb Carl Eugen Hoyos:
>>>>> 2019-03-26 15:56 GMT+01:00, Ulf Zibis <Ulf.Zibis at cosoco.de>:
>>>>>
>>>>>> I'm trying to benchmark -vf fillborders (added the timer
>>>>>> code in vf_fillborders.c), so Carl Eugen's suggestion
>>>>>> to use /dev/zero as input would not make sense.
>>>>> Please elaborate.
>>>> It seems I'm doing something wrong:
>>>>
>>>> ich at T500:~/Projects/ffmpeg/dev$ ./ffmpeg-p7b -y -stream_loop 1024
>>>> -i /dev/zero -vf fillborders=25:25:25:25:mirror -f null -
>>> $ ffmpeg -f rawvideo -s hd1080 -i /dev/zero -vf ... -t 1000 -f null -
>>>
>>> It may be that the performance of the filter cannot be
>>> tested like this, I don't know.
>> I suspect, you are right on not suitable for performance test.
> (I did not claim that, on the contrary.)
> Why not?
1.) There may be a shortcut in CPU architecture for copying nulls in
series (fillborders.c essentially does that) and more important ...
2.) Additionally I want to test on different ...
- number of planes
- color model /resolution
- bit depth

-Ulf