[FFmpeg-devel] [PATCH] swscale: Remove duplicated code

[Michael Niedermayer]

On Mon, Mar 25, 2019 at 12:37:37PM +0200, Lauri Kasanen wrote:
> On Mon, 25 Mar 2019 11:17:38 +0100
> Michael Niedermayer <michael at niedermayer.cc> wrote:
> 
> > On Sun, Mar 24, 2019 at 01:04:51PM +0200, Lauri Kasanen wrote:
> > > In this function, the exact same clamping happens both in the if and unconditionally.
> > >
> > > Signed-off-by: Lauri Kasanen <cand at gmx.com>
> > > ---
> > >  libswscale/output.c | 14 --------------
> > >  1 file changed, 14 deletions(-)
> >
> > The removed code is the one that should stay, the other should be
> > removed.
> > one check for a rarely true condition should be faster than 4 checks
> 
> Yes, I thought so too, but the commit that added the unconditional code
> says it fixes a bug...

yes, but its parent did not had the other cliping code, it should have
been a bugfix only as long as the other code wasnt there

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190325/3c53eec1/attachment.sig>