[FFmpeg-devel] Added support for XV video files

Moritz Barsnick barsnick at gmx.net
Mon Mar 25 12:14:19 EET 2019


On Mon, Mar 25, 2019 at 07:57:04 +0530, Shivam Goyal wrote:

> which would be intialised at the time of reading header) whenever we
> need to read from the input file, Which would recquire more processing
> and would make the program slow for both xv  and flv files

Good point. I agree that deciding whether to do rot with each and
every frame and other function calls. Can this not be optimized?

> total no. of occurences of the functions avio_r8, avio_rb16, avio_rb24,
> avio_rb32, avio_rb64 is around 39 . So, should i merge it with flvdec.c.

I cannot decide, I am just commenting. I was just pointing out that
copying a large amount of code for few modifications makes the whole
thing ineffective and a large maintenance burden.

Michael Niedermayer is the flvdec maintainer, and other core developers
will also know better what to do.

Moritz


More information about the ffmpeg-devel mailing list