[FFmpeg-devel] [PATCH v9 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

[Carl Eugen Hoyos]

2019-03-22 4:35 GMT+01:00, Sun, Jing A <jing.a.sun at intel.com>:
> Friday, March 22, 2019 7:52 AM, Carl Eugen:
>
>> +    if (avctx->pix_fmt == AV_PIX_FMT_YUV420P10LE) {
>> +        av_log(avctx, AV_LOG_DEBUG , "Encoder 10 bits depth
>> + input\n");
>> +
>> +        // Encoding the source frames of the compressed 10-bit format
>> +        // supported by SVT-HEVC requires an extra conversion operation
>> +        // from yuv420p10le to that format. Disable it for now in
>> ffmpeg.
>>Sorry for the misunderstanding:
>>What happens now (with this patch) if the user provides
>> AV_PIX_FMT_YUV420P10LE to this FFmpeg encoder?
>>And what should ideally happen?
>
> It works fine functionally. And we will save the extra step's cost time a
> little after we figures out how to and where to add the compressed format
> support in ffmpeg later.

What I meant is:
I don't understand the comment (and your mail), it says above the
functionality has to be disabled but you write it works fine.
The comment is (still) unclear imo.

Carl Eugen