[FFmpeg-devel] [FFmpeg-cvslog] lavf/latmenc: Error out for unsupported codecs.

[Nicolas George]

Carl Eugen Hoyos (12019-03-20):
> +    if (par->codec_id != AV_CODEC_ID_AAC && par->codec_id != AV_CODEC_ID_MP4ALS) {
> +        av_log(ctx, AV_LOG_ERROR, "Only AAC, LATM and ALS are supported\n");
> +        return AVERROR_INVALIDDATA;
> +    }

I think EINVAL is more correct in this kind of case: EINVAL for invalid
parameters from the application, INVALIDDATA for invalid data from the
files. A quick grep shows it is not the only place this is done like
that. I do not think it is urgent to fix it, just keep it in mind for
later if you agree.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190321/7b6e2617/attachment.sig>