[FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

Nick Renieris velocityra at gmail.com
Sun Mar 17 22:26:27 EET 2019


Στις Κυρ, 17 Μαρ 2019 στις 8:34 μ.μ., ο/η Paul B Mahol
<onemda at gmail.com> έγραψε:
> Please try with option adding instead(-subimage). It will ignore
> thumbnail and try to decode rest of image.
> Anyhow the return statement is invalid, as it breaks support for files
> that are already working just fine.

Sorry, I still fail to see how this is already 'working just fine'.
I'm not sure if I was clear, but the images generated *are thumbnail
sized* (I tested it myself).
Why would anyone expect this to happen by default?

What I would propose - if you want to keep this thumbnail
functionality - would be to add a -dngthumbnail or -thumbnail option
and keep the default as is in the commit, which is, from a users
perspective (IMO) much more intuitive. Perhaps the -thumbnail option
could then be mentioned in the warning, should the user want to use
it.

How does that sound?


More information about the ffmpeg-devel mailing list