[FFmpeg-devel] [PATCH] avformat/mov: Fix potential integer overflow in entry check in mov_read_trun()

Michael Niedermayer michael at niedermayer.cc
Sun Mar 17 12:34:40 EET 2019


No testcase

Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavformat/mov.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/mov.c b/libavformat/mov.c
index a7d444b0ee..ff9a9cbc95 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -4778,7 +4778,7 @@ static int mov_read_trun(MOVContext *c, AVIOContext *pb, MOVAtom atom)
     av_log(c->fc, AV_LOG_TRACE, "first sample flags 0x%x\n", first_sample_flags);
 
     // realloc space for new index entries
-    if((unsigned)st->nb_index_entries + entries >= UINT_MAX / sizeof(AVIndexEntry)) {
+    if((uint64_t)st->nb_index_entries + entries >= UINT_MAX / sizeof(AVIndexEntry)) {
         entries = UINT_MAX / sizeof(AVIndexEntry) - st->nb_index_entries;
         av_log(c->fc, AV_LOG_ERROR, "Failed to add index entry\n");
     }
-- 
2.21.0



More information about the ffmpeg-devel mailing list