[FFmpeg-devel] [PATCH]lavc/qtrle: Do not use aligned writes for odd addresses.

[Carl Eugen Hoyos]

2019-03-15 0:41 GMT+01:00, Hendrik Leppkes <h.leppkes at gmail.com>:
> On Fri, Mar 15, 2019 at 12:26 AM Carl Eugen Hoyos <ceffmpeg at gmail.com>
> wrote:
>>
>> 2019-03-15 0:13 GMT+01:00, Hendrik Leppkes <h.leppkes at gmail.com>:
>> > On Fri, Mar 15, 2019 at 12:05 AM Carl Eugen Hoyos <ceffmpeg at gmail.com>
>> > wrote:
>> >>
>> >> Hi!
>> >>
>> >> Attached patch fixes the qtrle crash on sparc for me.
>> >>
>> >
>> > It should be fine in cases where the pointer is being incremented by
>> > an aligned amount, ie. writing 32 and incrementing by 4, or 64 and 8,
>> > etc.
>>
>> Of course, thank you for the review!
>> New patch attached.
>>
>
> LGTM if tested.

I pushed the patch that fixed the crash on 32bit sparc
which I had tested first.

Attached patch fixes another fate crash on 64bit sparc, I
don't know if the change is sufficient for all use cases,
it passes fate.

The crash happens with pixel_ptr = 2852, rgb is 16-byte aligned.

Please comment, Carl Eugen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavc-qtrle-Do-not-use-aligned-64bit-write.patch
Type: text/x-patch
Size: 971 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190315/1ea58b70/attachment.bin>