[FFmpeg-devel] [PATCH] avutil/mem: Mark DECLARE_ASM_ALIGNED as visibility("hidden") for __GNUC__

[Fāng-ruì Sòng]

On Thu, Mar 14, 2019 at 9:59 AM Henrik Gramner <henrik at gramner.com> wrote:
>
> On Wed, Feb 20, 2019 at 8:03 PM Fāng-ruì Sòng
> <maskray-at-google.com at ffmpeg.org> wrote:
> > --- a/libavutil/mem.h
> > +++ b/libavutil/mem.h
> >
> > +#if defined(__GNUC__) && !(defined(_WIN32) || defined(__CYGWIN__))
> > +    #define DECLARE_HIDDEN __attribute__ ((visibility ("hidden")))
> > +#else
> > +    #define DECLARE_HIDDEN
> > +#endif
>
> libavutil/mem.h is a public header so any defines added should have
> appropriate prefixes (yes, the existing defines violate this which is
> something that should be addressed, but that's a different issue).

Do you have suggestions on the naming? av_declare_hidden?

> Alternatively maybe those macros should be moved to some internal
> header because I don't really see any value of having inline asm
> support macros public.

That would change too many files. I'd rather not do that in this patch.