[FFmpeg-devel] [PATCH 05/10] avformat/matroskadec: Remove non-incremental parsing of clusters

[Michael Niedermayer]

On Fri, Mar 08, 2019 at 10:25:59AM +0100, Andreas Rheinhardt wrote:
> When the new incremental parser was introduced, the old parser was
> kept, because the new parser was unable to handle the way SSA packets
> are put into Matroska. But since 2014 (since
> c7d8dbad14ed5fa3c217a4fc1790021d6c0b6416) this is no longer needed, so
> that the old parser can be completely removed.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at googlemail.com>
> ---
>  libavformat/matroskadec.c | 72 ++++++---------------------------------
>  1 file changed, 10 insertions(+), 62 deletions(-)

This affects seeking:

libavformat/tests/seek issues/388/Matrix.Reloaded.Trailer-640x346-XviD-1.0beta2-HE_AAC_subtitled.mkv -duration 400 >oldseek

The file appears to be available here:
https://samples.ffmpeg.org/Matroska/matrix/Matrix.Reloaded.Trailer-640x346-XviD-1.0beta2-HE_AAC_subtitled.mkv

--- oldseek	2019-03-08 23:08:21.380042329 +0100
+++ newseek	2019-03-08 23:08:02.048041745 +0100
@@ -8,7 +8,7 @@
 ret: 0         st:13 flags:1 dts: 86.750000 pts: 86.750000 pos:     -1 size: 50436
 ret:-1         st: 1 flags:0  ts: 250.577000
 ret: 0         st: 1 flags:1  ts: 13.471000
-ret: 0         st:13 flags:1 dts: 1.776000 pts: 1.776000 pos:     -1 size: 50436
+ret: 0         st:13 flags:1 dts: 0.000000 pts: 0.000000 pos:     -1 size: 50436
 ret:-1         st: 2 flags:0  ts: 176.365000
 ret: 0         st: 2 flags:1  ts: 339.259000
 ret: 0         st:13 flags:1 dts: 145.080000 pts: 145.080000 pos:     -1 size: 50436

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190308/d8553923/attachment.sig>