[FFmpeg-devel] [PATCH]lavf/mxfdec: Allow MXF parser to identify the Canon XF-HEVC codec/format for video essence

[Tomas Härdin]

This email chain got accidentally off-list. Putting it back on-list:

tis 2019-03-05 klockan 23:21 -0500 skrev Matthew McKenna:
> On 3/5/2019 10:21 AM, Tomas Härdin wrote:
> > mån 2019-03-04 klockan 23:30 -0500 skrev Matthew McKenna:
> > > On 3/4/2019 1:11 PM, Tomas Härdin wrote:
> > > > > +    { {
> > > > > 0x06,0x0e,0x2b,0x34,0x04,0x01,0x01,0x0a,0x0e,0x15,0x00,0x04,0x02,0x10
> > > > > ,0x00,0x01 }, 14,       AV_CODEC_ID_HEVC, NULL, 15 }, /* Canon XF-
> > > > > HEVC */
> > > > 
> > > > Got any idea what other ULs there are for this? If not then you should
> > > > probably be more strict and pick a matching length of 16 instead of 14.
> > > > Especially since you say there is no speficiation for it yet.
> > > > 
> > > > /Tomas
> > > 
> > > 
> > > Hi Tomas-
> > > 
> > > 
> > > I have gone thru all the permutations in the camera (different
> > > resolutions, bitrates, framerates), and they all generate the same UL.
> > > I will post them as references for others soon.
> > > 
> > > I have modified the patch in the attached to your recommendation of a
> > > match of length 16.
> > 
> > Looks good to me, but we probably want a FATE test too. I took a quick
> > look at your little corpus, and the files are kind of big. If you could
> > create a bunch of really short ones that would be great
> > 
> > /Tomas
> 
> 
> Hi Tomas-
> 
> 
> I have generated new samples, sourced with test pattern, some as short 
> as 1 second, about 1.2 megabytes per file.  If real-life clips are 
> required, or if the expectation is for me to perform the FATE tests, let 
> me know.
> 
> The location again, for your quick reference: 
> http://www.matthewmckenna.com/contrib/ffmpeg/xf-hevc/

I went and implemented FATE tests for this, as a separate patch. Both
it and Matthew's updated patch are attached.

I made a separate directory for these samples in $(SAMPLES)/mxf/xf-hevc 
locally with the README and all the verysmall samples in it:

  $ ls -l fate-suite/mxf/xf-hevc/|cut -d' ' -f 5-
  1158704 mar  6 05:05 2398p-1080-45M.mxf
  1160752 mar  6 05:05 2398p-1080-60M.mxf
  1242672 mar  6 05:05 2398p-4k-110M.mxf
  1229872 mar  6 05:05 2398p-4k-160M.mxf
  1164848 mar  6 05:05 2500p-1080-45M.mxf
  1160752 mar  6 05:05 2500p-1080-60M.mxf
  1242672 mar  6 05:05 2500p-4k-110M.mxf
  1229872 mar  6 05:05 2500p-4k-160M.mxf
  1254960 mar  6 05:05 2997p-1080-45M.mxf
  1229872 mar  6 05:05 2997p-1080-60M.mxf
  1354288 mar  6 05:05 2997p-4k-110M.mxf
  1312304 mar  6 05:05 2997p-4k-160M.mxf
  1296432 mar  6 05:05 5000i-1080-45M.mxf
  1278512 mar  6 05:05 5000i-1080-60M.mxf
  1225264 mar  6 05:05 5000p-1080-45M.mxf
  1221168 mar  6 05:05 5000p-1080-60M.mxf
  1315376 mar  6 05:05 5000p-4k-110M.mxf
  1263664 mar  6 05:05 5000p-4k-160M.mxf
  1394736 mar  6 05:05 5994i-1080-45M.mxf
  1392688 mar  6 05:05 5994i-1080-60M.mxf
  1285680 mar  6 05:05 5994p-1080-45M.mxf
  1295920 mar  6 05:05 5994p-1080-60M.mxf
  1416752 mar  6 05:05 5994p-4k-110M.mxf
  1367600 mar  6 05:05 5994p-4k-160M.mxf
      853 mar  6 05:06 README.txt

If someone with access could upload those samples there then we could
get both these patches pushed.

I took inspiration for the FATE code from how the HEVC tests are done.
Feedback welcome

/Tomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-the-Canon-XF-HEVC-UL-to-the-picture-essence-cont.patch
Type: text/x-patch
Size: 1399 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190306/7f9f79af/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-fate-Add-Canon-XF705-demux-tests.patch
Type: text/x-patch
Size: 126557 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190306/7f9f79af/attachment-0001.bin>