[FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

[Guo, Yejun]

> -----Original Message-----
> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf
> Of James Zern
> Sent: Friday, March 01, 2019 9:07 AM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support
> for ROI-based encoding
> 
> > >
> > > > +        if (avctx->codec_id == AV_CODEC_ID_VP8)
> > > > +            vp8_encode_set_roi(avctx, frame);
> > >
> > > The API only exists for VP8, or is this due to different quant scales or
> > > something?
> >
> > currently, VP9 ROI does not work, see my discussion at
> https://groups.google.com/a/webmproject.org/forum/#!topic/codec-
> devel/HVBRjoW0fTw,
> > the issue is confirmed by libvpx, and I'm helping to verify their new patch
> for the fix.
> >
> 
> It might be worth letting that conversation finish before pushing
> anything here. The API for VP9 hasn't changed, but there was a bug as
> you pointed out in that thread.
> 

yes, that's the reason I pending VP9 work. As for VP8 ROI, another thinking
is to first push vp8 roi, since libvpx is an external dependency and we don't
know the time when it is available for vp9 roi. Anyway, I'm open to both.

> > It is expected that VP9 ROI support will not be released in a short time, so I
> just add for vp8 roi.
> > There is something common between VP8/VP9 ROI, and I plan to extract
> an common function when doing the work for VP9 roi.
> >
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel