[FFmpeg-devel] [PATCH 1/3] avcodec/cfhd: remove unused function
vittorio.giovara at gmail.com
Thu Jun 27 18:35:10 EEST 2019
On Thu, Jun 27, 2019 at 9:44 AM Nicolas George <george at nsup.org> wrote:
> Kieran Kunhya (12019-06-27):
> > I'm happy to do it now that I am aware of the issue. I will do it when I
> > at home in a few days.
> Thanks. I am sure Steven will not mind waiting a few days.
> > This absolutism is absurd.
> Do you have an example of situation where dead code is good?
If i could add my 2 cents, for a reverse engineered codec it's important to
leave unused functions purely for documentation purposes, so that future
maintainers could implement and read about it right away, rather than
digging in a large and messy git history.
Additionally most compilers run passes that drop dead code already in a way
that does not affect runtime one bit. So I really don't see any gains in
removing these 14 lines of code.
More information about the ffmpeg-devel