[FFmpeg-devel] [PATCH 1/3] avcodec/cfhd: remove unused function

Kieran Kunhya kierank at obe.tv
Thu Jun 27 15:36:56 EEST 2019

On Thu, 27 Jun 2019 at 20:01, Nicolas George <george at nsup.org> wrote:

> Andreas Rheinhardt (12019-06-27):
> > The code is indeed dead atm. To quote myself from ticket 7886:
> > "Commit c64c97b972c7325a71440a352a7d541a8c92b2da has added support for
> > alpha channel decoding in Cineform HD (thereby fixing #6265), but
> > commit 9cefb9e7ec508900ba147e6977590f03456aa15c broke it again (the
> > function process_alpha introduced in the first commit is now not even
> > used any more -- thanks to Clang for reporting this). The sample
> > cineform_rgba_12b.mov from #6265 now decodes as before
> > c64c97b972c7325a71440a352a7d541a8c92b2da."
> Thanks for clarifying. If it is dead, it can be removed. If it is needed
> back, then it can be added back. Steven, go ahead if you want.

Why can this not be fixed properly? If the call to the function has been
removed accidentally, why make things worse and remove the function
This makes no sense at all.


More information about the ffmpeg-devel mailing list