[FFmpeg-devel] [PATCH 1/3] avcodec/cfhd: remove unused function

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Thu Jun 27 14:54:00 EEST 2019


Nicolas George:
> Paul B Mahol (12019-06-27):
>> No, code is not dead and should be kept, ask maintainer for confirmation.
> 
> The compiler says it is. I am sorry, but your statement without any
> proof seems less reliable than the diagnostics of the compiler and
> Steven's judgement.
> 
> As is, the code can and should be removed, unless there is a technical
> reason nobody mentioned yet.
> 
> Regards,
The code is indeed dead atm. To quote myself from ticket 7886:
"Commit c64c97b972c7325a71440a352a7d541a8c92b2da has added support for
alpha channel decoding in Cineform HD (thereby fixing #6265), but
commit 9cefb9e7ec508900ba147e6977590f03456aa15c broke it again (the
function process_alpha introduced in the first commit is now not even
used any more -- thanks to Clang for reporting this). The sample
cineform_rgba_12b.mov from #6265 now decodes as before
c64c97b972c7325a71440a352a7d541a8c92b2da."

- Andreas



More information about the ffmpeg-devel mailing list