[FFmpeg-devel] [PATCH 1/3] avcodec/cfhd: remove unused function

[Liu Steven]

> 在 2019年6月27日，下午4:37，Paul B Mahol <onemda at gmail.com> 写道：
> 
> On 6/27/19, Paul B Mahol <onemda at gmail.com> wrote:
>> On 6/27/19, Steven Liu <lq at chinaffmpeg.org> wrote:
>>> Signed-off-by: Steven Liu <lq at chinaffmpeg.org>
>>> ---
>>> libavcodec/cfhd.c | 14 --------------
>>> 1 file changed, 14 deletions(-)
>>> 
>>> diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c
>>> index 846d334b9b..616f5af193 100644
>>> --- a/libavcodec/cfhd.c
>>> +++ b/libavcodec/cfhd.c
>>> @@ -136,20 +136,6 @@ static inline void peak_table(int16_t *band, Peak
>>> *peak, int length)
>>>             band[i] = bytestream2_get_le16(&peak->base);
>>> }
>>> 
>>> -static inline void process_alpha(int16_t *alpha, int width)
>>> -{
>>> -    int i, channel;
>>> -    for (i = 0; i < width; i++) {
>>> -        channel   = alpha[i];
>>> -        channel  -= ALPHA_COMPAND_DC_OFFSET;
>>> -        channel <<= 3;
>>> -        channel  *= ALPHA_COMPAND_GAIN;
>>> -        channel >>= 16;
>>> -        channel   = av_clip_uintp2(channel, 12);
>>> -        alpha[i]  = channel;
>>> -    }
>>> -}
>>> -
>>> static inline void filter(int16_t *output, ptrdiff_t out_stride,
>>>                           int16_t *low, ptrdiff_t low_stride,
>>>                           int16_t *high, ptrdiff_t high_stride,
>>> --
>>> 2.17.2 (Apple Git-113)
>>> 
>>> 
>>> 
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel at ffmpeg.org
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>> 
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>> 
>> NAK
>> 
> 
> This code is needed for processing alpha, and should not be removed.
I remove it because i cannot found the caller for this API.
I think there should have one caller for this API, It will not be used if there have no caller, Isn’t it?

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".