[FFmpeg-devel] [PATCH v2] lavf/vf_find_rect: add the dual input support function

[Moritz Barsnick]

On Thu, Jun 27, 2019 at 10:12:35 +0800, lance.lmwang at gmail.com wrote:
> +This filter takes in two video input, the first input is considered
                                  ^ inputs
> +the "main" source and is passed unchanged to the output. The "second"
> +input is used as a rectangular object for finding, now the "second"
                                                    ^^^^^ Now?
The part from "now" - once you have clarified why the word "now"
belongs here - should be a separate sentence.

> -ffmpeg -i file.ts -vf find_rect=newref.pgm,cover_rect=cover.jpg:mode=cover new.mkv
> +ffmpeg -i file.ts -newref.pgm -filter_complex find_rect,cover_rect=cover.jpg:mode=cover new.mkv
                     ^^^^ This is certainly wrong.

> -ffmpeg -i file.ts -vf find_rect=newref.pgm,cover_rect=cover.jpg:mode=cover new.mkv
> +ffmpeg -i file.ts -newref.pgm -filter_complex find_rect,cover_rect=cover.jpg:mode=cover new.mkv
                     ^^^^ ditto

If you change the options behavior of a filter, you should bump
libavfilter micro version.

I can't just on most of the rest of your changes.

Moritz