[FFmpeg-devel] [PATCH v2] avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation
michael at niedermayer.cc
Wed Jun 26 14:25:45 EEST 2019
On Tue, Jun 25, 2019 at 06:47:30AM +0000, Jacob Siddall wrote:
> The previous calculation code did not account for the fact that the
> copy_offset for the start of the frame array is at index 0, yet the
> scan line number from the rfc4175 RTP header starts at 1.
> This caused 2 issues to appear:
> - The first scan line was being copied into the array where the second
> scan line should be. This caused the resulting video to have a green
> line at the top of it.
> - Since the packet containing the last scan line would fail the
> calculation, the packet with the RTP marker would not be processed
> which caused a log message saying "Missed previous RTP marker" to be
> outputted for each frame.
> Signed-off-by: Jacob Siddall <kobe at live.com.au>
> Changes in v2:
> - Don't handle packet if the line number is less than 1
> Section 12 in the VSF technical recommendation TR-03 specifies that the
> video scan line numbers should start at 1.
> libavformat/rtpdec_rfc4175.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
git seems to not like the patch:
Applying: avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation
Using index info to reconstruct a base tree...
error: patch failed: libavformat/rtpdec_rfc4175.c:205
error: libavformat/rtpdec_rfc4175.c: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
Patch failed at 0001 avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Does the universe only have a finite lifespan? No, its going to go on
forever, its just that you wont like living in it. -- Hiranya Peiri
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 181 bytes
Desc: not available
More information about the ffmpeg-devel