[FFmpeg-devel] [PATCH 1/2] avcodec/hevc_ps: Fix integer overflow with num_tile_rows and num_tile_columns

[James Almer]

On 6/25/2019 10:30 AM, James Almer wrote:
> On 6/25/2019 5:55 AM, Michael Niedermayer wrote:
>> +            num_tile_columns_minus1 >= sps->width - 1) {
> 
> Should be sps->ctb_width
> 
> From 7.4.3.3.1:
> 
> "num_tile_columns_minus1 plus 1 specifies the number of tile columns
> partitioning the picture. num_tile_columns_minus1 shall be in the range
> of 0 to PicWidthInCtbsY − 1, inclusive. When not present, the value of
> num_tile_columns_minus1 is inferred to be equal to 0."

Ugh, sorry, only now i looked at your second patch. You can ignore this part

Rest of my review still stands.