[FFmpeg-devel] [PATCH 1/3] avcodec/qdm2: Do not read out of array in fix_coding_method_array()

[Moritz Barsnick]

On Mon, Jun 24, 2019 at 01:01:02 +0200, Michael Niedermayer wrote:
> +                    if (sb + (j + k) / 64 > 29) {
[...]
>                      if (coding_method[ch][sb + (j + k) / 64][(j + k) % 64] > coding_method[ch][sb][j]) {

You could do the "sb + (j + k) / 64]" calculation only once and reuse
the result. OTOH, this code is full of magic numbers (notably 30, where
your 29 derives from) which could nicely make use of macros, but don't,
so it probably doesn't matter.

Moritz