[FFmpeg-devel] [PATCH v2] ffprobe: Fix memory leak

Derek Buitenhuis derek.buitenhuis at gmail.com
Fri Jun 21 17:39:51 EEST 2019


On 21/06/2019 15:26, James Almer wrote:
> Remove the three lines below as well before pushing. They are
> superfluous as av_packet_unref() does the same internally.

OK.

The documentation for av_packet_unref says it sets the 'remaining'
fields to default values, but av_init_packet says it sets the
'optional' fields to default values. Not clear if they mean
the same thing. Looking at the source, it's clear, but I prefer
not to do that, since it encourages relying on undocumented
behavior.

- Derek


More information about the ffmpeg-devel mailing list