[FFmpeg-devel] [PATCH] avcodec/alsdec: Consider frame_size in ra_block handling

[Michael Niedermayer]

On Thu, Jun 20, 2019 at 06:06:29PM +0200, Thilo Borgmann wrote:
> Am 20.06.19 um 16:17 schrieb Michael Niedermayer:
> > Fixes: out of array access
> > Fixes: 15277/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5184853437317120
> > 
> > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavcodec/alsdec.c | 9 +++++----
> >  1 file changed, 5 insertions(+), 4 deletions(-)
> > 
> > diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c
> > index e50a287f19..f94086efcb 100644
> > --- a/libavcodec/alsdec.c
> > +++ b/libavcodec/alsdec.c
> > @@ -789,14 +789,15 @@ static int read_var_block_data(ALSDecContext *ctx, ALSBlockData *bd)
> >  
> >      // read first value and residuals in case of a random access block
> >      if (bd->ra_block) {
> > -        if (opt_order)
> 
> pls add a comment here like:
> 
> // limit possibly corrupted opt_order

will do


> 
> and push if tested.

yes it fixes this issue but there are more related issues, ill
post a patch that should fix all.

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190620/e2c043f4/attachment.sig>