[FFmpeg-devel] [PATCH] avformat/oggdec: only parse headers before data

James Almer jamrial at gmail.com
Thu Jun 20 05:37:38 EEST 2019


On 6/19/2019 11:11 PM, Chris Cunningham wrote:
> On Wed, Jun 19, 2019 at 11:25 AM Michael Niedermayer
> <michael at niedermayer.cc> wrote:
> 
>     breaks:
>     ./ffmpeg -i bgc.sub.dub.ogm -vframes 3 -y test.webm
>     sample: http://samples.mplayerhq.hu/ogg/bgc.sub.dub.ogm
> 
>     [...]
> 
>     -- 
>     Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> 
> Thanks Michael.
> 
> That file is example of the "invalid" sort we were discussing
> previously. As I understand it, the spec requires that data packets not
> be interleaved with header packets - the headers for all streams should
> conclude before data packets begin. In this file we see a few headers
> followed by a data packet (stream 0), followed by more headers for
> streams 1 - 3. 
> 
> We knew this change would break such files. Can we live it? James, any
> workaround? If not I'm still open to
> setting st->internal->need_context_update as discussed in the earlier
> patch (https://patchwork.ffmpeg.org/patch/11983/) 

I'm fine going the need_context_update route if trying to skip extra
headers is being so problematic.

> 
> Chris



More information about the ffmpeg-devel mailing list