[FFmpeg-devel] [PATCH 03/18] filter_units: Unref packet on failure

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Mon Jun 17 06:42:08 EEST 2019


According to the API, the packet structure a bsf receives must not be
touched on failure, yet filter_units nevertheless did it.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
---
 libavcodec/filter_units_bsf.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavcodec/filter_units_bsf.c b/libavcodec/filter_units_bsf.c
index bc2ca288dd..0876693c81 100644
--- a/libavcodec/filter_units_bsf.c
+++ b/libavcodec/filter_units_bsf.c
@@ -153,6 +153,8 @@ static int filter_units_filter(AVBSFContext *bsf, AVPacket *out)
         goto fail;
 
 fail:
+    if (err < 0)
+        av_packet_unref(out);
     ff_cbs_fragment_reset(ctx->cbc, frag);
     av_packet_free(&in);
 
-- 
2.21.0



More information about the ffmpeg-devel mailing list