[FFmpeg-devel] [PATCH] avformat/oggparseogm: unknown codec triggers error
Reimar.Doeffinger at gmx.de
Sun Jun 16 15:47:43 EEST 2019
On 14.06.2019, at 17:01, James Almer <jamrial at gmail.com> wrote:
> On 6/14/2019 11:52 AM, Reimar Döffinger wrote:
>> On 14.06.2019, at 03:15, Chris Cunningham <chcunningham at chromium.org> wrote:
>>> Only "succeed" to read a header if the codec is valid. Otherwise
>>> return AVERROR_INVALIDDATA.
>> That doesn't sound right to me, an unknown codec in (possibly) a single stream is not an error.
>> I understood the discussion more to say the if it's an unknown codec, we should not try to override valid codec configuration with a broken one.
> I did request this change, seeing that returning codec_id none in this
> scenario results in a crash at a later point due to conflicting parameters.
> Do you suggest we should limit the change to only reject any duplicate
> header that may show up after the first one (and before the first data
I don't know or understand the details, but I understood the suggestion as "do not override a valid codec ID to NONE".
Either way, I would have suggested only skipping the affected stream - but I admit I have not checked how far-reaching it is to return an error here.
More information about the ffmpeg-devel