[FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

[Marton Balint]

On Wed, 12 Jun 2019, Michael Niedermayer wrote:

> On Tue, Jun 11, 2019 at 03:21:41PM -0500, Amir Z wrote:
>> Thanks Michael Niedermayer for looking into this
>>
>> What I am trying to solve is having a way to detect concealed decoding
>> errors by the caller to avcodec_receive_frame.
>>
>> Should I add a general value e.g. #define
>> FF_DECODE_ERROR_DECODE_ERROR_OCCURRED 4 ?
>
> I suggest
> FF_DECODE_ERROR_CONCEALMENT_ACTIVE or something similar and then always
> set this for all cases of error concealment
> Its more informative than just knowing there was an error

Concealment is a consequence. Error_flags should refer to the cause. A 
generic UNKNOWN error seems much better to me if it is not feasible to 
determine the cause.

Regards,
Marton