[FFmpeg-devel] [PATCH] avcodec/h264_sei: Add experimental acces to truncated SEI data

Reimar Döffinger Reimar.Doeffinger at gmx.de
Wed Jun 5 21:51:37 EEST 2019


On 04.06.2019, at 22:33, Antonin Gouzer <antonin.gouzer at gmail.com> wrote:

> Hello,
> Thanks for your response.
> It's difficult to say if this is a common issue.
> I have hundred of thousands of files like this from an editor.
> 
> Even the off by one Size is not standart compliant and it would be
> incorrect to not report it as an error/warning

Warning yes, but as far as I know FFmpeg policy generally is to support all files that exist in the wild without extra options.
So I would maybe start with suggesting if you can convince the authors of that editor to fix it (doesn't fix existing files, but at least we won't have more of them generated).
Secondly, I would suggest to accept (with warning) the off-by-one case, unless stricter than default compliance is requested.
Lastly, up to you what to do about the case where it is off by more than one.
I think it should probably still be rejected at default compliance selection, but don't care whether to not support it at all or at experimental level.
Though last word is up to the maintainer.


More information about the ffmpeg-devel mailing list