[FFmpeg-devel] [PATCH V2 2/2] checkasm/vf_gblur: add test for horiz_slice simd

[Song, Ruiling]

> -----Original Message-----
> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf
> Of Michael Niedermayer
> Sent: Wednesday, June 5, 2019 4:16 AM
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH V2 2/2] checkasm/vf_gblur: add test for
> horiz_slice simd
> 
> On Tue, Jun 04, 2019 at 04:42:09PM +0800, Ruiling Song wrote:
> > Signed-off-by: Ruiling Song <ruiling.song at intel.com>
> > ---
> >  tests/checkasm/Makefile   |  1 +
> >  tests/checkasm/checkasm.c |  3 ++
> >  tests/checkasm/checkasm.h |  1 +
> >  tests/checkasm/vf_gblur.c | 67
> +++++++++++++++++++++++++++++++++++++++
> >  tests/fate/checkasm.mak   |  1 +
> >  5 files changed, 73 insertions(+)
> >  create mode 100644 tests/checkasm/vf_gblur.c
> 
> this fails here: (ubuntu x86-64)
> 
> Test checkasm-vf_gblur failed. Look at tests/data/fate/checkasm-
> vf_gblur.err for details.
> checkasm: using random seed 1608403213
> test failed comparing 258.619 with 212.24 (abs diff=46.3793 with EPS=0.01)
> SSE4.1:
>    horiz_slice_sse4 (vf_gblur.c:60)
>  - vf_gblur.horiz_slice [FAILED]
> checkasm: 1 of 1 tests have failed
> make: *** [fate-checkasm-vf_gblur] Error 1
Hi Michael,

Thanks so much for testing. I tried on three different hardware with Ubuntu 18.04, and failed to reproduce the issue. It's really strange:(
But I reproduce a failure on WIN64. the root-cause of the bug is I missed the important fact that the 'int' parameter was passed in using lower 32bit of the 64bit register. The upper 32bit may have garbage.
I have fixed the issue in V3. Hope it can solve the issue you met. Please help take a test when you have time.
If it cannot fix your issue, please help share me your CPU info, Ubuntu version, gcc version, and nasm/yasm version. Thanks so much!

Thanks!
Ruiling
> 
> 
> 
> [...]
> --
> Michael     GnuPG fingerprint:
> 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> You can kill me, but you cannot change the truth.