[FFmpeg-devel] [PATCH 1/5] startcode: Use common macro

[Andreas Rheinhardt]

Michael Niedermayer:
> On Sun, Jun 02, 2019 at 12:47:15AM +0200, Andreas Rheinhardt wrote:
>> The reasons are cosmetics and preparation for future patches that will
>> have even more cases.
>>
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
>> ---
>>  libavcodec/startcode.c | 37 +++++++++++++++++++------------------
>>  1 file changed, 19 insertions(+), 18 deletions(-)
> 
> This is not the same code, the way memory is read changes, 
> the index is changed to a pointer. 
> Why are these changes done ? And if they are done, they should be
> benchmarked
> 
> Thanks
> 
I'm sorry. I remember actually doing benchmarks of an earlier version
[1] which suddenly was quite faster after switching from index to
pointer, so I simply changed it. I must have forgotten to document it
in the commit message.

- Andreas

[1]: https://github.com/mkver/FFmpeg/commits/start_2
Warning: Very raw. IIRC the whole unaligned stuff does not yet work
for it and it definitely doesn't work on BE.