[FFmpeg-devel] [PATCH 3/3] lavf/qsv: use av_cold for init/uninit

Li, Zhong zhong.li at intel.com
Mon Jun 3 06:00:09 EEST 2019


> From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf
> Of Carl Eugen Hoyos
> Sent: Saturday, June 1, 2019 4:41 AM
> To: FFmpeg development discussions and patches
> <ffmpeg-devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH 3/3] lavf/qsv: use av_cold for init/uninit
> 
> Am Fr., 31. Mai 2019 um 10:01 Uhr schrieb Zhong Li <zhong.li at intel.com>:
> >
> > Signed-off-by: Zhong Li <zhong.li at intel.com>
> > ---
> >  libavfilter/vf_deinterlace_qsv.c | 2 +-
> >  libavfilter/vf_overlay_qsv.c     | 2 +-
> >  libavfilter/vf_scale_qsv.c       | 4 ++--
> >  3 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/libavfilter/vf_deinterlace_qsv.c
> > b/libavfilter/vf_deinterlace_qsv.c
> > index bee10c220f..80217c8419 100644
> > --- a/libavfilter/vf_deinterlace_qsv.c
> > +++ b/libavfilter/vf_deinterlace_qsv.c
> > @@ -83,7 +83,7 @@ typedef struct QSVDeintContext {
> >      int mode;
> >  } QSVDeintContext;
> >
> > -static void qsvdeint_uninit(AVFilterContext *ctx)
> > +static av_cold void qsvdeint_uninit(AVFilterContext *ctx)
> >  {
> >      QSVDeintContext *s = ctx->priv;
> >      QSVFrame *cur;
> > diff --git a/libavfilter/vf_overlay_qsv.c
> > b/libavfilter/vf_overlay_qsv.c index 9aabb594ba..2a4dc5cb58 100644
> > --- a/libavfilter/vf_overlay_qsv.c
> > +++ b/libavfilter/vf_overlay_qsv.c
> > @@ -345,7 +345,7 @@ static int overlay_qsv_init(AVFilterContext *ctx)
> >      return 0;
> >  }
> >
> > -static void overlay_qsv_uninit(AVFilterContext *ctx)
> > +static av_cold void overlay_qsv_uninit(AVFilterContext *ctx)
> >  {
> >      QSVOverlayContext *vpp = ctx->priv;
> >
> > diff --git a/libavfilter/vf_scale_qsv.c b/libavfilter/vf_scale_qsv.c
> > index 7d593b2b21..db7715fc1b 100644
> > --- a/libavfilter/vf_scale_qsv.c
> > +++ b/libavfilter/vf_scale_qsv.c
> > @@ -109,7 +109,7 @@ typedef struct QSVScaleContext {
> >      char *format_str;
> >  } QSVScaleContext;
> >
> > -static int qsvscale_init(AVFilterContext *ctx)
> > +static av_cold int qsvscale_init(AVFilterContext *ctx)
> >  {
> >      QSVScaleContext *s = ctx->priv;
> >
> > @@ -126,7 +126,7 @@ static int qsvscale_init(AVFilterContext *ctx)
> >      return 0;
> >  }
> >
> > -static void qsvscale_uninit(AVFilterContext *ctx)
> > +static av_cold void qsvscale_uninit(AVFilterContext *ctx)
> 
> Patch looks fine to me.
> 
> Carl Eugen

Thanks. Will apply


More information about the ffmpeg-devel mailing list