[FFmpeg-devel] [PATCH] avformat/hcom: Remove unused variables

Carl Eugen Hoyos ceffmpeg at gmail.com
Sat Jun 1 00:57:09 EEST 2019

Am Fr., 31. Mai 2019 um 23:43 Uhr schrieb Andreas Rheinhardt
<andreas.rheinhardt at gmail.com>:
> The variables huffcount, rsrc_size and data_size were all set but not
> used. Therefore they have been removed. The entailed a chance to
> compactify calls to avio_skip; it has been used.
> This fixes -Wunused-but-set-variable warnings in GCC.
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
> My earlier patch [1] forgot to compactify the calls to avio_skip.
> The loss of information regarding the offsets of certain fields
> doesn't seem important to me.

I don't maintain this file but I would prefer a variant where the fields
would be kept in comments to simplify future debugging (which
implies to compacting).

Carl Eugen

More information about the ffmpeg-devel mailing list