[FFmpeg-devel] [PATCH 2/2] lavfi/vf_thumbnail_cuda: fix operator precedence bug

Philip Langdale philipl at overt.org
Tue Jul 30 11:18:21 EEST 2019


On 2019-07-30 15:51, Rodger Combs wrote:
> Discovered via a warning when building with clang
> ---
>  libavfilter/vf_thumbnail_cuda.cu | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/vf_thumbnail_cuda.cu 
> b/libavfilter/vf_thumbnail_cuda.cu
> index c73e49fbc6..d4d4d791f6 100644
> --- a/libavfilter/vf_thumbnail_cuda.cu
> +++ b/libavfilter/vf_thumbnail_cuda.cu
> @@ -71,7 +71,7 @@ __global__ void
> Thumbnail_ushort2(cudaTextureObject_t ushort2_tex,
>      {
>          ushort2 pixel = tex2D<ushort2>(ushort2_tex, x, y);
>          atomicAdd(&histogram[(pixel.x + 128) >> 8], 1);
> -        atomicAdd(&histogram[256 + (pixel.y + 128) >> 8], 1);
> +        atomicAdd(&histogram[256 + ((pixel.y + 128) >> 8)], 1);
>      }
>  }

LGTM

--phil


More information about the ffmpeg-devel mailing list