[FFmpeg-devel] [PATCH 6/6] avcodec/flicvideo: More strictly check chunk size for FLI_COPY

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sun Jul 21 14:58:53 EEST 2019


On 19.07.2019, at 21:46, Michael Niedermayer <michael at niedermayer.cc> wrote:

> On Fri, Jul 19, 2019 at 03:54:19PM +0200, Paul B Mahol wrote:
>> On 7/19/19, Michael Niedermayer <michael at niedermayer.cc> wrote:
>>> On Sat, Jun 22, 2019 at 01:29:36AM +0200, Michael Niedermayer wrote:
>>>> Fixes: Timeout (40sec -> 13sec)
>>>> Fixes:
>>>> 15417/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLIC_fuzzer-5679812615602176
>>>> 
>>>> Found-by: continuous fuzzing process
>>>> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
>>>> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
>>>> ---
>>>> libavcodec/flicvideo.c | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>> 
>>> will apply
>>> 
>> 
>> Why? This actually is breaking old code.
>> Can you please stop committing such kind of patches?
> 
> This patch was on the mailing list since a month, why do you point
> out a problem with it only once i say that i intend to apply it ?

You are sending an awful lot of these patches.
For my part it is purely random whether and when I manage to look at one even for code I somewhat know.
I imagine a lot of other people are struggling to keep up as well.
If you want better reviews you might want to think about better ways to categorise them to reduce review burden - e.g. by risk level.


More information about the ffmpeg-devel mailing list