[FFmpeg-devel] [PATCH] avformat/mov: fix return code for trun box with no sample entries

Gyan ffmpeg at gyani.pro
Sun Jul 21 12:50:21 EEST 2019



On 21-07-2019 02:21 PM, Paul B Mahol wrote:
> On 7/20/19, Gyan <ffmpeg at gyani.pro> wrote:
>> Affected files can now be demuxed. Verified with John Stebbins. FATE
>> passes.
>>
>> Gyan
>>
> You removed negative check, so not ok.

entries is unsigned (in the code as well as in the standard). So the 
value read from file will be >= 0. Even after adjustment for index size 
overflow, it cannot become negative.

Gyan


More information about the ffmpeg-devel mailing list