[FFmpeg-devel] [PATCH 3/4] avcodec/vorbisdec: Check vlc for floor0 dec vector offset

Paul B Mahol onemda at gmail.com
Sun Jul 21 12:27:44 EEST 2019


On 7/21/19, Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Mon, Jul 08, 2019 at 01:18:04AM +0200, Michael Niedermayer wrote:
>> Fixes: out of array access
>> Fixes:
>> 15649/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VORBIS_fuzzer-5729191309344768
>>
>> Found-by: continuous fuzzing process
>> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
>> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
>> ---
>>  libavcodec/vorbisdec.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> will apply

Are you sure returning that value is correct approach?

Correct value to return is usually INVALIDDATA.

>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> The educated differ from the uneducated as much as the living from the
> dead. -- Aristotle
>


More information about the ffmpeg-devel mailing list