[FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

[Michael Niedermayer]

On Thu, Jul 18, 2019 at 10:22:23PM +0200, Michael Niedermayer wrote:
> On Thu, Jul 18, 2019 at 02:44:46PM +0000, Eoff, Ullysses A wrote:
> > > From: ffmpeg-devel [mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf Of Michael Niedermayer
> > > On Mon, Jul 15, 2019 at 06:38:35PM +0800, Linjie Fu wrote:
> > > > +    { "autoscale",        HAS_ARG | OPT_BOOL | OPT_SPEC |
> > > > +                          OPT_EXPERT | OPT_INPUT,                                { .off = OFFSET(autoscale) },
> > > > +        "automatically insert correct scale filters" },
> > > 
> > > I think this description is inadequate to understand what the option does.
> > > Scale filters are inserted at various places (for example within a filter
> > > graph). This option here affects a specific case.
> > > 
> > 
> > Would this be sufficient?
> > 
> > "automatically insert a scale filter to scale the output of all frames to
> >   match the resolution of the initial frame"
> 
> this sounds better, yes
> 
> 
> > 
> > If not, any other suggestions?
> 
> maybe it could say how this relates to the filter graph/chain. 
> the user doenst know from this if this occurs before or after the
> filter graph.
> 
> 
> Also what happens when a encoder/muxer does not support this ?

I presume it fails in this case and if so a flag is needed
something like AV_CODEC_CAP_VARIABLE_DIMENSIONS

This would also decrease the number of cases where this doesnt
work without providing a clear error message

Thanks

[...]


-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190720/0649013e/attachment.sig>