[FFmpeg-devel] [PATCH 2/3] lavf/aviobuf: make AVSEEK_SIZE usable from outside.

Nicolas George george at nsup.org
Sat Jul 20 01:08:59 EEST 2019


Hendrik Leppkes (12019-07-20):
> That seems like a particularly dumb compiler "feature". Checking
> bitmasks for a set bit seems like a rather standard if condition.

Maybe, to each their own, but it saved me a few times, so personally I
like it, especially since the double-parentheses is an
obvious and unobtrusive way of silencing it.

(Personally I would prefer explicitly "!= 0", but that is not FFmpeg's
coding style.)

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190720/0900a6a8/attachment.sig>


More information about the ffmpeg-devel mailing list