[FFmpeg-devel] [PATCH] libavformat/subfile: Fix SEEK_CUR and SEEK_END seeking

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Fri Jul 19 19:30:00 EEST 2019


Nicolas George:
> Andreas Rheinhardt (12019-07-15):
>> Up until now, when performing a SEEK_END seek, the subfile protocol
>> ignored the desired position (relative to EOF) and used the current
>> absolute offset in the input file instead.
>>
>> And when performing a SEEK_CUR seek, the current position has been
>> ignored.
>>
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
>> ---
>> Sorry for the noise of another email, but I just found out that SEEK_CUR
>> is buggy as well. This probably hasn't been detected earlier because
>> avio_seek translates SEEK_CUR to SEEK_SET internally.
> 
> I think this patch is necessary, and I intend to apply it.
> 
> But in the meantime, can you test if this patch:
> 
> https://ffmpeg.org/pipermail/ffmpeg-devel/2019-July/246765.html
> 
> does resolve the problem with concat: that made you look into it?
> 
> Regards,
> 
It does solve the seeking problem with concat and subfile, just as
fixing subfile alone does; also, applying both commits works fine, too.

- Andreas


More information about the ffmpeg-devel mailing list