[FFmpeg-devel] [PATCH] Issue#6001:Fix for incorrect refs frame count in ffprobe

Hendrik Leppkes h.leppkes at gmail.com
Thu Jul 18 10:08:22 EEST 2019


On Thu, Jul 18, 2019 at 5:33 AM Mukund Manikarnike <mukunm at gmail.com> wrote:
>
> Hi,
>
> Please find the patch for issue#6001 attached.

The patch is not correct. As you may have noticed,
ff_h264_decode_seq_parameter_set does not set *any* parameters in
avctx, that is because decoding a SPS and actually activating and
using the SPS are seperate actions. As such, this is the wrong spot to
do this.
The SPS values should be set in the avctx in the place where the  SPS
is activated for decoding image data, not when the SPS itself is being
decoded.

This would probably be something like h264_init_ps, which does appear
to already set avctx->refs.

- Hendrik


More information about the ffmpeg-devel mailing list