[FFmpeg-devel] [PATCH] lavc/videotoolboxenc: add hdr10, linear, hlg color transfer function for videotoolboxenc

[Limin Wang]

On Wed, Jul 17, 2019 at 10:53:08AM -0400, Vittorio Giovara wrote:
> On Tue, Jul 16, 2019 at 10:29 PM Limin Wang <lance.lmwang at gmail.com> wrote:
> 
> > On Tue, Jul 16, 2019 at 09:36:32PM -0400, Rick Kern wrote:
> > > Testing for the new transfer functions when compiling for OSX 10.12
> > reports
> > > the color settings as "yuv420p(tv, bt2020nc/bt2020/reserved)" in ffprobe.
> > > Is "reserved" (0) the expected default when the transfer function isn't
> > > supported?
> > mac 10.13 support:
> > kCVImageBufferTransferFunction_SMPTE_ST_2084_PQ
> > kCVImageBufferTransferFunction_ITU_R_2100_HLG
> >
> > OSX 10.14 support:
> > kCVImageBufferTransferFunction_Linear
> >
> > For 10.12, the HAVE_* macros should be detected as 0 if correct.
> >
> 
> 0 is a reserved value in the color specification and should be avoided if
> possible.
> Would it be possible to fallback on 2 (unknown) when these macros are not
> found?

My old mac pro don't support hevc, so I can test it. Please check the
HAVE* is 0

➜  ffmpeg.git git:(videotoolboxenc_v2) ✗ sw_vers -productVersion
10.11.6
➜  ffmpeg.git git:(videotoolboxenc_v2) ✗ grep "HAVE_KCV*" config.h
#define HAVE_KCMVIDEOCODECTYPE_HEVC 1
#define HAVE_KCVPIXELFORMATTYPE_420YPCBCR10BIPLANARVIDEORANGE 0
#define HAVE_KCVIMAGEBUFFERTRANSFERFUNCTION_SMPTE_ST_2084_PQ 0
#define HAVE_KCVIMAGEBUFFERTRANSFERFUNCTION_ITU_R_2100_HLG 0
#define HAVE_KCVIMAGEBUFFERTRANSFERFUNCTION_LINEAR 0

I have submited another patch to fix it, please try whether it's OK.

> -- 
> Vittorio
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".