[FFmpeg-devel] [PATCHv4] avcodec: Add librav1e encoder

Derek Buitenhuis derek.buitenhuis at gmail.com
Mon Jul 15 18:27:42 EEST 2019


On 15/07/2019 15:53, James Almer wrote:
>>> AV_BASE64_DECODE_SIZE(strlen(avctx->stats_in));
>>
>> I copied this directly from libtheoraenc.c which has had this for more than 10
>> years... is it wrong? Should it be changed too?
> 
> It's not wrong, that helper macro was added three years ago and it
> expands to the same code, except promoting the intermediary result to
> int64_t to prevent overflow.
> And i think it should ideally be changed in libtheora/libvpx as well, yes.

OK.

- Derek


More information about the ffmpeg-devel mailing list