[FFmpeg-devel] [PATCH] lavc: Add libsvt-av1 encoder wrapper

[Sun, Jing A]

-----Original Message-----
From: Li, Zhong 
Sent: Saturday, July 13, 2019 1:23 AM
To: Sun, Jing A <jing.a.sun at intel.com>; ffmpeg-devel at ffmpeg.org
Cc: Daryl Seah <daryl.seah at intel.com>; Tang, Zhizhen <zhizhen.tang at intel.com>
Subject: RE: [PATCH] lavc: Add libsvt-av1 encoder wrapper

> I prefer to contribute on FFmpeg mainline instead of a forked branch. However, once get aligned in the community, of course I can contribute to the branch as well.
> (Many SVT core library and API patches hold on my hand will also be sent out after my leave of next 2~3 weeks)
> And let me provide more detail about the purposes:
> 1. SVT encoders (01.org/svt ) show very impressive performance benefit and get much attention . 
  Let's collect some feedback as early as possible, this patch is not call for merge bug call for feedback, comments. Not only collect feedback of SVT FFmpeg wrapper, but also feedback of SVT core libraries and APIs.

SVT AV1 GitHub is not a forked branch, but a project every SVT developer is working together on. When you have any changes you would like to make to its FFmpeg plugin, you'd better submit those to the SVT AV1 Github first, so that the SVT maintainers and other plugin authors could review them before making them public.

>  e.g : SVT-AV1 reused libaom. If you enable both libsvt-av1 and libaom as static link, then will have name conflict. 
>  Such issue is not easily found if you keep wrapper patch on https://github.com/OpenVisualCloud/SVT-AV1/tree/master/ffmpeg_plugin ,
> But will easily found if works on FFmpeg mainline. 

That's a known issue: https://github.com/OpenVisualCloud/SVT-AV1/issues/119, which was submitted by me at Feb. Please look into it.

> 2. Many review comments from community (including mine) haven't been well addressed in SVT-HEVC wrapper patch. 
  This patch is just to address them, probably it can be a reference of SVT-HEVC wrapper too. 

Which one is not addressed?

> 3. As mentioned in the patch annotation, this wrapper patch is a response of ticket #7914, though it is not quite mature.