[FFmpeg-devel] [PATCH 1/6] avcodec/iff: Add "else" to make code look prettier

[Michael Niedermayer]

On Sun, Jul 14, 2019 at 03:55:54PM +1000, Peter Ross wrote:
> On Sat, Jul 13, 2019 at 10:25:01PM +0200, Michael Niedermayer wrote:
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavcodec/iff.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavcodec/iff.c b/libavcodec/iff.c
> > index c6e2359b00..7f1c589d7c 100644
> > --- a/libavcodec/iff.c
> > +++ b/libavcodec/iff.c
> > @@ -284,7 +284,7 @@ static int extract_header(AVCodecContext *const avctx,
> >              if (s->bpp > 8) {
> >                  av_log(avctx, AV_LOG_ERROR, "Invalid number of hold bits for HAM: %u\n", s->ham);
> >                  return AVERROR_INVALIDDATA;
> > -            } if (s->ham != (s->bpp > 6 ? 6 : 4)) {
> > +            } else if (s->ham != (s->bpp > 6 ? 6 : 4)) {
> >                  av_log(avctx, AV_LOG_ERROR, "Invalid number of hold bits for HAM: %u, BPP: %u\n", s->ham, s->bpp);
> >                  return AVERROR_INVALIDDATA;
> >              }
> > -- 
> > 2.22.0
> 
> well spotted. please push.

will do

thanks

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Never trust a computer, one day, it may think you are the virus. -- Compn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190714/bc320bec/attachment.sig>