[FFmpeg-devel] [PATCH v1 1/2] libavformat/avio: Fix for the unexpected file close which will cause fd 0 is closed

[Michael Niedermayer]

On Tue, Jun 18, 2019 at 06:45:12PM +0800, lance.lmwang at gmail.com wrote:
> From: Limin Wang <lance.lmwang at gmail.com>
> 
> Signed-off-by: Limin Wang <lance.lmwang at gmail.com>
> ---
>  libavformat/avio.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/libavformat/avio.c b/libavformat/avio.c
> index 663789ec02..c1d10ee8c3 100644
> --- a/libavformat/avio.c
> +++ b/libavformat/avio.c
> @@ -568,7 +568,6 @@ int avio_open_dir(AVIODirContext **s, const char *url, AVDictionary **options)
>    fail:
>      av_free(ctx);
>      *s = NULL;
> -    ffurl_close(h);
>      return ret;
>  }
>  
> @@ -594,7 +593,6 @@ int avio_close_dir(AVIODirContext **s)
>          return AVERROR(EINVAL);
>      h = (*s)->url_context;
>      h->prot->url_close_dir(h);
> -    ffurl_close(h);
>      av_freep(s);
>      *s = NULL;
>      return 0;

have you checked this for memleaks ?

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who would give up essential Liberty, to purchase a little
temporary Safety, deserve neither Liberty nor Safety -- Benjamin Franklin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20190712/d15bea50/attachment.sig>