[FFmpeg-devel] [PATCHv4] avcodec: Add librav1e encoder

Moritz Barsnick barsnick at gmx.net
Tue Jul 9 23:23:11 EEST 2019


Hi,

On Tue, Jul 09, 2019 at 19:34:33 +0100, Derek Buitenhuis wrote:
> Port to the new send/receive API by: James Almer <jamrial at gmail.com>.

Two nits:

> +Sets the minimum quantizer (ceiling) to use when in bitrate mdoe.

Typo -> "mode"

> +        av_log(avctx, AV_LOG_ERROR, "Unknown return code from rav1e_send_frame.\n");
> +        return AVERROR_UNKNOWN;

Feel free to include the error code in the message, as you did in
librav1e_receive_packet().

Moritz


More information about the ffmpeg-devel mailing list