[FFmpeg-devel] [PATCH] lavf/vf_stack: add keep_dar option for vstack and hstack

[Limin Wang]

On Mon, Jul 08, 2019 at 01:52:16PM +0200, Moritz Barsnick wrote:
> On Mon, Jul 08, 2019 at 18:48:46 +0800, lance.lmwang at gmail.com wrote:
> > + at item keep_dar
> > +stack with 1/nb_inputs of each inputs screen to keep the same DAR, Default is 0.
>                                   ^
> Probably "input's". Is screen the correct term here at all? (In three
> places in the patch.)
> 
> > +    { "keep_dar", "stack with 1/nb_inputs of each inputs screen to keep the same DAR", OFFSET(keep_dar), AV_OPT_TYPE_INT, {.i64=0}, 0, 1, .flags = FLAGS },
> 
> AV_OPT_TYPE_BOOL
> 
Yes, I'll update for my local, thank for the review.

> Not sure about the actual implementation, can't judge.
> 
> Cheers,
> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".