[FFmpeg-devel] [PATCH 00/18] cbs: Use ff_bsf_get_packet_ref etc.

[Mark Thompson]

On 17/06/2019 04:42, Andreas Rheinhardt wrote:
> Hello,
> 
> this patchset is mainly about switching the bitstream filters using cbs
> from ff_bsf_get_packet to ff_bsf_get_packet_ref (except trace_headers,
> which also uses it). But in the course of doing so, I also found several
> other (usually small) things to improve and this is included here.
> 
> This partially conflicts with my earlier patchset [1]; I will rebase it
> on top of this and resend it.
> 
> - Andreas
> 
> [1]: https://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/244952.html
> 
> Andreas Rheinhardt (18):
>   cbs: Allow non-blank packets in ff_cbs_write_packet
>   av1_metadata: Avoid allocations and copies of packet structures
>   filter_units: Unref packet on failure
>   filter_units: Don't use fake loop
>   filter_units: Reindent after previous commit
>   filter_units: Avoid allocations and copies of packet structures
>   av1/h264_metadata, filter_units: Count down when deleting units
>   h264_metadata: Avoid allocations and copies of packet structures
>   h264_metadata: Localize code for display orientation
>   cbs: Remove superfluous checks for ff_cbs_delete_unit
>   cbs_h264, h264_metadata: Deleting SEI messages never fails
>   h264_redundant_pps: Avoid allocations and copies of packet structures
>   h264_redundant_pps: Fix looping over an access unit's units
>   h265_metadata: Avoid allocations and copies of packet structures
>   h265_metadata: Correct error check
>   mpeg2_metadata: Avoid allocations and copies of packet structures
>   mpeg2_metadata: Localize inserting of sequence display extensions
>   vp9_metadata: Avoid allocations and copies of packet structures
> 
>  libavcodec/av1_metadata_bsf.c       | 28 +++------
>  libavcodec/cbs.c                    |  3 +-
>  libavcodec/cbs.h                    | 12 +++-
>  libavcodec/cbs_h264.h               |  8 +--
>  libavcodec/cbs_h2645.c              | 12 ++--
>  libavcodec/filter_units_bsf.c       | 62 ++++++++-----------
>  libavcodec/h264_metadata_bsf.c      | 95 +++++++++--------------------
>  libavcodec/h264_redundant_pps_bsf.c | 25 +++-----
>  libavcodec/h265_metadata_bsf.c      | 18 ++----
>  libavcodec/mpeg2_metadata_bsf.c     | 50 ++++++---------
>  libavcodec/vp9_metadata_bsf.c       | 16 ++---
>  11 files changed, 121 insertions(+), 208 deletions(-)

1-9 all LGTM, applied.  (10+ superseded by following series, will continue there.)

Thanks,

- Mark